Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quote): adjust locale import path #12035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(quote): adjust locale import path #12035

wants to merge 1 commit into from

Conversation

m4olivei
Copy link
Contributor

Related Ticket(s)

Closes #12034

Description

Adjusts the import path for LocaleAPI to be more verbose and workable for downstream application bundlers. Used the same path as locale-modal-composite.ts here.

Changelog

Changed

  • Adjusts import path for the LocaleAPI in quote component

@m4olivei m4olivei added bug Something isn't working dev Needs some dev work adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants v2 labels Sep 17, 2024
@m4olivei m4olivei requested a review from a team as a code owner September 17, 2024 15:12
@m4olivei m4olivei requested review from ariellalgilmore and removed request for a team September 17, 2024 15:12
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12035/index.html

Built with commit: 625fb7b6bba81e586eeef5c6256ebeb55150b386

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12035/index.html

Built with commit: 625fb7b6bba81e586eeef5c6256ebeb55150b386

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12035/index.html

Built with commit: 625fb7b6bba81e586eeef5c6256ebeb55150b386

bruno-amorim
bruno-amorim approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bruno-amorim bruno-amorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for all the help Matt!!

@m4olivei m4olivei added the test: e2e used for automated e2e testing label Sep 17, 2024
@m4olivei m4olivei closed this Sep 17, 2024
@m4olivei m4olivei reopened this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-amorim bruno-amorim bruno-amorim approved these changes

@andy-blum andy-blum Awaiting requested review from andy-blum

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants test: e2e used for automated e2e testing v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[quote]: Bundler error for quote component in the latest release (v2.13.0)
3 participants
@m4olivei @ibmdotcom-bot @bruno-amorim