Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make text ellipsis in profile popover #2183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make text ellipsis in profile popover #2183

wants to merge 1 commit into from
+10 −0

Conversation

FadhlanR
Copy link
Contributor

Screenshot 2025-02-21 at 13 33 06

@FadhlanR FadhlanR requested a review from a team February 21, 2025 06:36
@github-actions GitHub Actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   23m 20s ⏱️ -24s
773 tests ±0  771 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
778 runs  ±0  776 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 7c5ad00. ± Comparison against base commit 05d4cb6.

jurgenwerk
jurgenwerk approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@jurgenwerk jurgenwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a title attribute already present but I think it's a good practice to add it on elements with ellipsis overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habdelra habdelra habdelra approved these changes

@jurgenwerk jurgenwerk jurgenwerk approved these changes

@richardhjtan richardhjtan richardhjtan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FadhlanR @habdelra @jurgenwerk @richardhjtan