Alternate cookie/redirect policy #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Hannes, first of all I feel bad for not answering so long, but I had some other stuff to focus on first. Sorry for that :-( Thanks for your contribution on the extension. I don't think I will take over the changes though, since as far as I understood this will change the current behaviour of the extension. I'm not really actively developing on this extension anymore, but I try to maintain it for a couple of upcoming Typo3 versions, so I tend to keep the changes as small as possible. Regards, Carsten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Carsten!
A couple of days ago, I forked your extension to implement a new cookie policy. In this version the cookies just serve to prevent an automatic redirection from standard to mobile. They do not force a redirect anymore. The user can navigate back to the mobile version of the page by typing the mobile domain name into the address bar. Additionally the cookie domain is now configurable, so the cookie can span multiple sub domains.
If you are interested, please feel free to merge.
Cheers,
Hannes