Fix Geant4 setup when single Coulomb scattering is enabled #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails for positrons with `src/celeritas/random/distribution/RejectionSampler.hh:90: celeritas: precondition failed: fmax_ >= f_"`
- Construct proton when Coulomb scattering is enabled: `Geant4 error: G4ParticleDefinition should be created in PreInit state G4ParticleDefintion::G4ParticleDefinition(): 'PART101' failed` - Always construct Coulomb scattering model with `isCombined=true` (cross sections are zero otherwise) - Set polar angle limit between SS and MSC to zero if single Coulomb scattering is used
amandalund
added
bug
sethrj
reviewed
Sep 7, 2024
sethrj
approved these changes
Sep 10, 2024
sethrj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few little issues I encountered when trying to run celer-sim with Coulomb scattering enabled (but not the problems with the model limits described in #1391):
G4Protonin the celer EM physics list when Coulomb scattering is enabled (fixesGeant4 error: G4ParticleDefinition should be created in PreInit state G4ParticleDefintion::G4ParticleDefinition(): 'PART101' failed)G4eCoulombScatteringModelwith the default value ofisCombined(avoiding all zero cross sections).