-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakey tests and improve the test log output #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inteon I remember you writing some code which watches until a Namespace has actually been deleted.
I think that would help here, because I think root cause of the flakiness is that the next test and its controller-runtime manager are starting up before the Namespace of the previous test has been fully deleted, and reconciling the resources associated with that previous test.
Meanwhile I will try using Eventually
to periodically check that the resources have all been deleted.
Don't attempt to delete test namespace because envtest doesn't support namespace deletion. Signed-off-by: Richard Wall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the namespace issue.
All test are passing and all resources are removed between tests.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've been trying to fix the flakiness in the
pull-cert-manager-approver-policy-verify
tests:The tests originally attempted to delete the test namespace after each test, but this can't work because envtest doesn't provide the controller responsible for garbage collection of namespaced resources: