Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Commit

Permalink
Remove remaining FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
cespare committed Jan 13, 2019
1 parent f790d55 commit 47b5a18
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion ryu.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func pow5Bits(e int32) int32 {
return int32((uint32(e)*1217359)>>19 + 1)
}

// FIXME(caleb): Document how these are optimized.
// These boolToXxx all inline as a movzx.

func boolToInt(b bool) int {
if b {
Expand Down
1 change: 0 additions & 1 deletion ryu64.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ func shiftRight128(v uint128, shift int32) uint64 {
// Check this here in case a future change requires larger shift
// values. In this case this function needs to be adjusted.
assert(shift < 64, "shift < 64")
// FIXME: optimize
return (v.hi << uint64(64-shift)) | (v.lo >> uint(shift))
}

Expand Down

0 comments on commit 47b5a18

Please sign in to comment.