Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vulnerabilities #28 #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix vulnerabilities #28 #29

wants to merge 8 commits into from

Conversation

elhayef
Copy link

@elhayef elhayef commented Mar 12, 2024

#28
fix vulnerabilities #28

@elhayef
Copy link
Author

elhayef commented Mar 12, 2024

/approve

@elhayef
Copy link
Author

elhayef commented Mar 12, 2024

@STRRL

@elhayef
Copy link
Author

elhayef commented Mar 12, 2024

LGTM!

@elhayef
Copy link
Author

elhayef commented Mar 12, 2024

/merge

@elhayef
Copy link
Author

elhayef commented Mar 12, 2024

@caniszczyk @Gallardot @siddontang @jeefy who can review ?

@elhayef
Copy link
Author

elhayef commented Mar 13, 2024

@STRRL @cwen0 can you please approve ?

go.mod Outdated Show resolved Hide resolved
@elhayef
Copy link
Author

elhayef commented Mar 13, 2024

/lgtm

@chaotic-prow
Copy link

chaotic-prow bot commented Mar 13, 2024

@elhayef: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elhayef
Copy link
Author

elhayef commented Mar 13, 2024

@STRRL i have changed :) thx for review man :)

@elhayef elhayef requested a review from STRRL March 13, 2024 11:44
@STRRL
Copy link
Member

STRRL commented Mar 14, 2024

hi @elhayef, I don't see the changes here

Maybe you forgot to push your code?

Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elhayef PTAL

go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elhayef PTAL

@elhayef elhayef requested a review from STRRL March 17, 2024 14:05
@elhayef
Copy link
Author

elhayef commented Mar 17, 2024

@STRRL change the relevant can we push it :)

@elhayef
Copy link
Author

elhayef commented Mar 19, 2024

@STRRL any chance ?

@elhayef
Copy link
Author

elhayef commented Mar 20, 2024

@STRRL please :)

Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
Signed-off-by: Elhay Efrat <[email protected]>
@elhayef
Copy link
Author

elhayef commented Mar 20, 2024

/LGTM

@chaotic-prow
Copy link

chaotic-prow bot commented Mar 20, 2024

@elhayef: you cannot LGTM your own PR.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elhayef
Copy link
Author

elhayef commented Mar 20, 2024

/approve

@STRRL
Copy link
Member

STRRL commented Sep 17, 2024

/approve
/lgtm

@chaotic-prow
Copy link

chaotic-prow bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elhayef, STRRL

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants