fix(table): last row out of viewport #731
Open
+2
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because cursor is an index (starts at 0), we need to substract 1 to the viewport height to get the correct start position.
caarlos0
approved these changes
Feb 11, 2025
|
Wait before merging this. It looks like it introduces undesirable behavior in some cases. |
System-Glitch
force-pushed
the
bug/table-viewport
branch
from
adfc2cd to
9a07c32
Compare
|
Ready for re-review. I removed unecessary code related to the viewport Y offset. I didn't see any difference after removing it because we only render the relevant rows in There is one bug remaining: the selector stays at the bottom when moving up. I tested it on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a table cannot display all its rows, the viewport allows scrolling. However, the last row isn't visible.
For example for a table size of 7, the viewport height will be 5 (-2 because of the header). When setting the cursor at position 5, the 6th row should be visible, but isn't. This PR fixes this.
Because cursor is an index (starts at 0), we need to substract 1 to the viewport height to get the correct start position. Otherwise the viewport thinks it can display one more row than it can actually fit when rendering.