docs: viewport horizontal scroll, gutter, highlight examples #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
commented
Feb 3, 2025
Comment on lines
+58
to
+59
| vp.KeyMap.Left.SetEnabled(false) | ||
| vp.KeyMap.Right.SetEnabled(false) |
There was a problem hiding this comment.
not sure if this should be disabled by default?
There was a problem hiding this comment.
hmm good question. I'd look at existing tools like less and more
caarlos0
changed the title
|
I'm playing with this a bit and it looks like not all matches are being highlighted and the highlighting jumps a bit (highlights here are in green, with the selected one a darker green. Unless I'm missing something? pager.mov |
|
@meowgorithm looks like you only set the selected highlight style, there's a highlight style as well |
|
I have these two set, but I'm seeing the same behavior in the example here as well. m.viewport.HighlightStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("238")).Background(lipgloss.Color("34"))
m.viewport.SelectedHighlightStyle = lipgloss.NewStyle().Foreground(lipgloss.Color("238")).Background(lipgloss.Color("47")) |
|
Btw, this is a solid API. Nice work. |
This reverts commit 6e1be92.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example usage of charmbracelet/bubbles#697