Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocation: move app folder content to store folder #1020

Conversation

boodland
Copy link
Contributor

Relocated store content to a new location to avoid mix logic with app router one

Issue link / number:

#1019 sub issue of #702

What changes did you make?

Relocated store logic from app folder to store folder

Why did you make the changes?

Next.js uses app folder to place the app router logic. Moving any other logic outside that folder leads to a cleaner and more focused structure

Did you run tests?

Yes

Copy link

vercel bot commented Jul 12, 2024

@boodland is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@boodland
Copy link
Contributor Author

boodland commented Jul 12, 2024

@eleanorreem, @annarhughes please have a look to it when possible in order to avoid/minimise conflicts as it has changes affecting a lot of files., it is also blocking me to continue with the rest of the migration. Thanks!

@eleanorreem
Copy link
Contributor

@boodland thanks! All looks good to me 😄

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 4:16pm

@eleanorreem eleanorreem merged commit cea519e into chaynHQ:develop Jul 16, 2024
7 checks passed
@boodland boodland deleted the refactor--move-app-folder-content-to-store-folder branch July 19, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants