Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the reactions set_from_email redirect_url is legit #314

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Check that the reactions set_from_email redirect_url is legit #314

merged 4 commits into from
Jul 27, 2023

Conversation

issyl0
Copy link
Contributor

@issyl0 issyl0 commented Jul 20, 2023

@issyl0 issyl0 force-pushed the fix-user-provided-redirect-vuln branch from c2622e7 to 1dd548e Compare July 20, 2023 13:26
@issyl0 issyl0 force-pushed the fix-user-provided-redirect-vuln branch from 1dd548e to 8152b73 Compare July 20, 2023 13:26
@seanmarcia seanmarcia changed the base branch from master to main July 23, 2023 04:29
tarebyte
tarebyte reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tarebyte tarebyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there a test we can write to make sure this doesn't regress later?

@tarebyte tarebyte merged commit d43589b into main Jul 27, 2023
5 checks passed
@tarebyte tarebyte deleted the fix-user-provided-redirect-vuln branch July 27, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarebyte tarebyte tarebyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @tarebyte