Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#581) Add recommendations for sxs packages #587

Merged
merged 2 commits into from
Nov 1, 2022
Merged

(#581) Add recommendations for sxs packages #587

merged 2 commits into from
Nov 1, 2022

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Oct 28, 2022

Description Of Changes

Add recommendations for things folks can do for "side by side" installations of the same software.

Motivation and Context

We're deprecating the builtin sxs installation methods so we need to document alternatives for now.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

Fixes #581

@vexx32 vexx32 requested review from gep13 and pauby October 28, 2022 14:26
pauby
pauby previously requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome start! Thank you!

@pauby pauby requested a review from AdmiringWorm October 28, 2022 15:56
AdmiringWorm
AdmiringWorm reviewed Oct 28, 2022
View reviewed changes
vexx32 added a commit to vexx32/docs that referenced this pull request Oct 28, 2022
@vexx32 @pauby
(chocolatey#587) Apply amendments from reviews
64eb3ee 
Co-authored-by: Paul Broadwith <[email protected]>
@gep13
(maint) Replace usage of term gallery
c16baf6 
gallery -> Chocolatey Community Repository
gep13
gep13 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Nov 1, 2022

@vexx32 thanks for getting this updated!

@gep13 gep13 dismissed pauby’s stale review November 1, 2022 15:12

Requested changes have been applied.

@gep13 gep13 enabled auto-merge November 1, 2022 15:12
@gep13 gep13 merged commit 91e1098 into chocolatey:master Nov 1, 2022
choco-bot pushed a commit that referenced this pull request Nov 1, 2022
@web-flow
Continuous Integration Publish: 91e1098
7b30a0a 
Merge pull request #587 from vexx32/sxs-package-recs

(#581) Add recommendations for sxs packages
@vexx32 vexx32 deleted the sxs-package-recs branch November 1, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm left review comments

@pauby pauby pauby left review comments

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on the alternatives to the now deprecated side by side installations
4 participants
@vexx32 @gep13 @AdmiringWorm @pauby