Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webpack config, Babel and split src and dist files #16

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

qathom
Copy link

@qathom qathom commented Dec 5, 2017

Hello @chrisdavies,

Thank you for making tlite!
In this PR, I wanted to suggest you to separate source (src/) and production (dist/) files so that it is easier to make tlite in ES6 and work with preprocessors such as Sass.
The default output in the webpack.config.js file (libraryTarget) is umd.
I runned the tests and it looks fine.

Installation:

npm install
npm run build // generates dist files
npm run test // run tests

@chrisdavies
Copy link
Owner

First, thanks for using tlite and for putting a pull request together.

I purposely don't use Babel for my library projects, as they almost all initially start off as a "let me see if I can make this small and light-weight" and Babel tends to (or at least it used to) produce unnecessary bloat.

You mention SASS, but I'm not a fan of it. I do think this project (and all of my other ones, for that matter should be using http://cssnext.io/).

I have started using ES5 + Rollup for my newer libraries (see https://github.com/chrisdavies/tiny-date-picker), as it is very effective at producing optimized library output.

Anyway, sorry to be a Debbie downer, but I don't want to bring webpack, babel, or SCSS into this project.

I'd definitely be down with bringing Rollup and cssnext in, though, and changing this to use the more standard /src and /dist layout, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants