Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cloudflare, prometheus_remote_write and splunk to service ports [sc-115821] #116

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nicolasparada
Copy link
Contributor

@nicolasparada nicolasparada commented Nov 4, 2024

Updated service port detection and made sure to include:

  • cloudflare
  • prometheus_remote_write
  • splunk

Also fixed some issues with syslog mode property.

[sc-115821]

@nicolasparada nicolasparada changed the title add clouddlare, prometheus_remote_write and splunk to service ports add cloudflare, prometheus_remote_write and splunk to service ports Nov 4, 2024
@nicolasparada nicolasparada changed the title add cloudflare, prometheus_remote_write and splunk to service ports fix: add cloudflare, prometheus_remote_write and splunk to service ports [sc-115821] Nov 4, 2024
Copy link
Contributor

@niedbalski niedbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niedbalski niedbalski merged commit b9c7e2f into main Nov 5, 2024
1 check passed
@niedbalski niedbalski deleted the service-ports branch November 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants