build: Fix embroider optimized CI builds #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready? |
There's [an issue with ember-cli-deprecation-workflow](ember-cli/ember-cli-deprecation-workflow#133) that causes an error during CI for the embroider optimized build. I think we can remove `ember-cli-deprecation-workflow` from this addon because it does not seem to be doing anything useful but maybe I'm missing something? This was originally added in cibernox@c10dd8e as part of cibernox#1431 but there is not really much context to go off of as far as why it was added. It seems like maybe it was added while debugging GitHub Actions and accidentally left laying around? - ember-cli/ember-cli-deprecation-workflow#133 - https://github.com/embroider-build/embroider/tree/main/packages/test-setup#embroideroptimizedembertryconfig
|
@cibernox should be ready now |
This removes `ember-cli-fastboot` because it is not currently compatible with embroider optimized builds. I believe `ember-cli-fastboot` was added as a dependency so `ember-power-select` could run some tests to ensure compatibility. This makes sense but AFAICT the tests to check fastboot compatibility have not actually been running since 2016. Since these fastboot tests have not actually been running for so long, IMO it makes sense to remove all of this for now and revisit fastboot tests separately. - Stopped running fastboot tests cibernox@1b9f90d#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L13
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
embroiderOptimizedember-try scenario that runs as part of CI mostly by removing the dependency on other addons that cause issues:ember-cli-fastbootember-cli-deprecation-workflowember-fetchRemoving
ember-cli-fastbootThis removes
ember-cli-fastbootbecause it is not currently compatible with embroider optimized builds.I believe
ember-cli-fastbootwas added as a dependency soember-power-selectcould run some tests to ensure compatibility. This makes sense but AFAICT the tests to check fastboot compatibility have not actually been running since 2016. Since these fastboot tests have not actually been running for so long, IMO it makes sense to remove all of this for now and revisit fastboot tests separately.Here is the commit where the command to run the fastboot tests was removed 1b9f90d#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L13
Removing
ember-cli-deprecation-workflowThere's an issue with ember-cli-deprecation-workflow that causes an error during CI for the embroider optimized build.
I think we can remove
ember-cli-deprecation-workflowfrom this addon because it does not seem to be doing anything useful but maybe I'm missing something?This was originally added in c10dd8e as part of #1431 but there is not really much context to go off of as far as why it was added. It seems like maybe it was added while debugging GitHub Actions and accidentally left laying around?
Removing
ember-fetchThis also removes the direct dependency on
ember-fetchbecause it was only used in the docs/tests and causes some issues related to embroider.The issue was reported here ember-cli/ember-fetch#622 and the fix was basically to get around the issue by using native promises rather than RSVP. This root of the issue was not actually fixed yet and here is the open issue embroider-build/embroider#1195