prog, map: add nil checks for value marshaller #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibor
force-pushed
the
marshal-nil-checks
branch
from
f5ea3f1
to
7c8dd1d
Compare
In case of programs or maps as map value types, the value marshaling results in a panic in case of a nil pointer. For other types this is not a problem since sysenc.Marshal does a nil check. This commit adds a nil check to the internal helper for marshaling programs and maps. Signed-off-by: Tobias Böhm <[email protected]>
ti-mo
force-pushed
the
marshal-nil-checks
branch
from
7c8dd1d
to
e521b5b
Compare
|
Thanks! Pushed a small fixup. |
|
Great, thanks for the quick fixup and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of programs or maps as map value types, the value marshalling results in a panic in case of a nil pointer. For other types this is not a problem since sysenc.Marshal does a nil check.
This commit adds a nil check to the internal helper for marshalling programs and maps.