Separate serde #110
Draft
Separate serde #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enabled default features specified in the spec. - Removed patch versions from crates with stable minors. - Added better support for number casting. - Cleaned up imports. Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
This reverts commit 30a545a. Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/separate-serde
branch
from
286c9ea to
e9f2107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde is yet another dependency that's not strictly necessary and it would be nice to be able to disable it with a feature.
The only problem is that this crate currently relies on
serdeto convert primitive types intoValue, so this PR needs to address that as well.This PR has been separated out of #109, to keep the prior PR simple and clean.