Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about passkey behavior in dev #1931

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

@victoriaxyz victoriaxyz requested a review from a team as a code owner January 17, 2025 23:38
@victoriaxyz victoriaxyz changed the title add info about passkey behavior in dev for custom-flows/passkeys and add info about passkey behavior in dev Jan 17, 2025
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1931

Comment on lines 30 to 31
- Create custom [`/sign-up` and `/sign-in` routes](/docs/custom-flows/overview) in your application instead of using Account Portal
- Create the passkey directly through Account Portal instead of your local application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify that it doesn't need to be a full 'custom flow' and it can just be a path that hosts a <SignIn /> or <SignUp /> component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, how's this? b1d2b90

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that works. The other workaround is to create passkeys on both, but lets not over complicate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the feedback! :D

@victoriaxyz victoriaxyz requested a review from royanger January 18, 2025 00:00
Copy link
Contributor

@jeremy-clerk jeremy-clerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think this is good information to relay to our users as it may not be immediately apparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants