Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for syncing with upstream #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prepare for syncing with upstream #264

wants to merge 2 commits into from

Commits on Aug 16, 2024

  1. Support linking with a runtime cpp library 

    As of https://boringssl-review.googlesource.com/c/boringssl/+/66288,
libssl allows a C++ runtime dependency. As such, we need to link with a
cpp runtime library. Implementation is inspired heavily from
google/boringssl@54c956b.

Before releasing this change, we'll need to figure out a way to support
this for windows.
    @rushilmehra
    rushilmehra committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ad1f9bb View commit details
    Browse the repository at this point in the history

  2. Fix bug with accessing memzero'd X509StoreContext in tests 

    As of https://boringssl-review.googlesource.com/c/boringssl/+/64141,
X509_STORE_CTX_cleanup will zero the memory allocated to the
X509_STORE_CTX. Because X509StoreContextRef::init invokes
X509_STORE_CTX_cleanup once the with_context closure has finished,
calling X509StoreContextRef::verify_result (or any API really) is going
to be invalid because memory has been zerod out. This is a pretty big
footgun, so maybe we should consider screaming a bit louder for this
case.
    @rushilmehra
    rushilmehra committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ae7a587 View commit details
    Browse the repository at this point in the history