Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue parsing Image Details from API due to incorrect struct json field #1379

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

itsdax
Copy link

@itsdax itsdax commented Aug 27, 2023

Description

Issue is described here: #1378
API returns the metadata object under the field meta. However the SDK expects the field metadata thus it always drops this data from the response.

Has your change been tested?

Yes - after changing the struct field for Metadata to meta, GetImage calls return images with Metadata field populated.

Screenshots (if appropriate):

https://developers.cloudflare.com/api/operations/cloudflare-images-image-details

Refer to the response example of Image details. Specifically the meta field. The current SDK expects metadata and thus it always drops the metadata from the response.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1379 (12bd338) into master (b9ac804) will increase coverage by 0.00%.
Report is 203 commits behind head on master.
The diff coverage is 49.62%.

@@           Coverage Diff            @@
##           master    #1379    +/-   ##
========================================
  Coverage   48.33%   48.34%            
========================================
  Files         133      139     +6     
  Lines       13023    13749   +726     
========================================
+ Hits         6295     6647   +352     
- Misses       5201     5453   +252     
- Partials     1527     1649   +122     
Files Changed Coverage Δ
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
account_members.go 65.54% <ø> (ø)
account_roles.go 53.84% <ø> (ø)
accounts.go 50.81% <ø> (ø)
addressing_address_map.go 39.04% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
... and 121 more

... and 1 file with indirect coverage changes

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! added some notes inline.

images.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 87e330f into cloudflare:master Aug 28, 2023
10 checks passed
@github-actions github-actions bot added this to the v0.76.0 milestone Aug 28, 2023
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.76.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants