Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker_url to OutputEntryDeployment #8042

Closed

Conversation

Maximo-Guk
Copy link
Member

@Maximo-Guk Maximo-Guk commented Feb 5, 2025

Fixes #8041

Add worker_url to OutputEntryDeployment from wrangler deploy

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Wrangler's output file is not currently documented

@Maximo-Guk Maximo-Guk added the e2e Run wrangler e2e tests on a PR label Feb 5, 2025
@Maximo-Guk Maximo-Guk self-assigned this Feb 5, 2025
@Maximo-Guk Maximo-Guk requested a review from a team as a code owner February 5, 2025 23:05
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: b74cef1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 5, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-wrangler-8042

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8042/npm-package-wrangler-8042

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-wrangler-8042 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-workers-bindings-extension-8042 -O ./cloudflare-workers-bindings-extension.0.0.0-v6108e79c7.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6108e79c7.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-create-cloudflare-8042 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-kv-asset-handler-8042

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-miniflare-8042

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-pages-shared-8042

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-unenv-preset-8042

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-vite-plugin-8042

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-vitest-pool-workers-8042

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-workers-editor-shared-8042

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-workers-shared-8042

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13168323894/npm-package-cloudflare-workflows-shared-8042

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Maximo-Guk Maximo-Guk force-pushed the maximo/add-worker-url-to-output-entry-deployment branch from 426241d to b74cef1 Compare February 5, 2025 23:12
@Maximo-Guk Maximo-Guk marked this pull request as draft February 5, 2025 23:26
@Maximo-Guk Maximo-Guk closed this Feb 5, 2025
@Maximo-Guk
Copy link
Member Author

Maximo-Guk commented Feb 5, 2025

Closing, as what I really wanted here was the targets. Which are already present in OutputEntryDeployment.

@Maximo-Guk Maximo-Guk removed their assignment Feb 5, 2025
@Maximo-Guk Maximo-Guk deleted the maximo/add-worker-url-to-output-entry-deployment branch February 10, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Write worker_url to deploy artifact file
1 participant