Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for interpolation search for asset manifest lookup #8044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregBrimble
Copy link
Contributor

Fixes WC-3154

Adds analytics, a bunch of tests, and introduces a zero percent gated interpolation search method as an alternative to the binary search that we're doing today. It should be a bit faster.

Zero percent for now. Let's just get the analytics in place, and then we can play with the percentage a bit and see what effect it has in production.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not covered
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal package

@GregBrimble GregBrimble requested review from a team as code owners February 6, 2025 04:47
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 418ecb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-wrangler-8044

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8044/npm-package-wrangler-8044

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-wrangler-8044 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-workers-bindings-extension-8044 -O ./cloudflare-workers-bindings-extension.0.0.0-v57c7bcea4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v57c7bcea4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-create-cloudflare-8044 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-kv-asset-handler-8044

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-miniflare-8044

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-pages-shared-8044

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-unenv-preset-8044

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-vite-plugin-8044

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-vitest-pool-workers-8044

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-workers-editor-shared-8044

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-workers-shared-8044

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13187994491/npm-package-cloudflare-workflows-shared-8044

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble force-pushed the interpolation-search-zero-percent branch 2 times, most recently from d33e412 to 7bda81d Compare February 6, 2025 07:01
@GregBrimble GregBrimble force-pushed the interpolation-search-zero-percent branch from 7bda81d to c4959e6 Compare February 6, 2025 17:34
@GregBrimble GregBrimble force-pushed the interpolation-search-zero-percent branch from c4959e6 to 418ecb7 Compare February 6, 2025 21:12
@GregBrimble GregBrimble force-pushed the interpolation-search-zero-percent branch from 418ecb7 to 44c87aa Compare February 6, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants