-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Adds possibility to call BBS to retrieve stats for application's processes states. #129
base: master
Are you sure you want to change the base?
Draft: Adds possibility to call BBS to retrieve stats for application's processes states. #129
Conversation
2d914f6
to
71eb8b8
Compare
Waiting for cloudfoundry/cloud_controller_ng!3863 to be merged and released. |
Waiting for cloudfoundry/cli!2933 to be merged. |
337713f
to
aea97bd
Compare
3d9c60e
to
8550d41
Compare
8550d41
to
e1bad98
Compare
28375f6
to
6d6a189
Compare
@gmllt the BBS API URL, what would that be ? => https://github.com/cloudfoundry/cf-deployment/blob/a0f8634a507108481c6b08304719ab7babace102/cf-deployment.yml#L151 |
I receive always
|
got it to work, setting skip-ssl to true made the trick. Unfortunately the logs do not give you any insights why the connection did not work. I don't think we do a fallback to the old logic, as it gets removed nevertheless. I would remove the fallback and make the BBS config optional, e.g. if the BBS config is not present do not gather the summary metrics as maybe not everyone wants to make BBS available to their monitoring VMs. |
The purpose of this PR is to propose the use of BBS to fetch the RUNNING state of the main application process.
This should help to avoid calls to
/v2/space/:space_guid/summary
endpointsbbs internal client is configurable with :
If bbs is not configured or unreachable, the code switch to the old method using
/v2/space/:space_guid/summary
to retrieve application running instances number.Buildpacks information are retrieve with the new relationship introduced since CAPI 1.189.0