-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-route options via CF cli #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename all occurences of least-connections
to least-connection
.
Thanks, done! |
changed "one can" to "you can" added colons to procedure steps changed "execute" to "run" removed "via" (Latinisms are not used in CF doc set)
I made formatting and wording edits. |
Thanks, Anita @anita-flegg. Is using "you can" instead of "one can" less formal? |
@Dariquest , "you can" might be considered less formal, but it's really a style choice. And once a style choice has been made, it's important to maintain internal consistency across the doc set. The whole doc set uses "you" to speak directly to the reader. So the bottom line is that the change to "you can" in this case is to maintain consistency within the CF doc set. |
I am for consistency either, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more remark: To not get confused with the map-route
command, having MY-APP
for both the app name and route: Maybe use MY-HOST
throughout the whole site for the route name.
Co-authored-by: Clemens Hoffmann <[email protected]>
Co-authored-by: Clemens Hoffmann <[email protected]>
Co-authored-by: Clemens Hoffmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round :)
Co-authored-by: Clemens Hoffmann <[email protected]>
Documentation adjustments for
cloudfoundry/cli#3372
cloudfoundry/cli#3366