RND-423 Upgraded passport-saml to v4
#2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubama
commented
Apr 12, 2023
| return new Strategy( | ||
| { | ||
| path: '/auth/saml/callback', | ||
| entryPoint: getConfig().app.auth.loginPageUrl, | ||
| cert | ||
| cert, | ||
| issuer: 'onelogin_saml' |
There was a problem hiding this comment.
In v3, this was the default value for this now mandatory property.
|
@kubama I performed few manual tests using Okta-configured Cloudify Manager with Stage package created from Ref.: node-saml/passport-saml#814 As |
qooban
approved these changes
Apr 25, 2023
|
@qooban Great, thanks for taking care of testing 👍. |
PatrycjaKubiczek
pushed a commit
that referenced
this pull request
Nov 15, 2023
PatrycjaKubiczek
added a commit
that referenced
this pull request
Nov 17, 2023
* Bump version * RND-96 Add helm wrapper endpoint (#2471) * RD-7122: Increased timeout for redirection after blueprint deployment (#2473) * RND-96 Add HELM chart wrapper frontend (#2472) * RD-7088: Migrated away from using @ts-expect-error annotation (#2464) * RD-7088: Marked type annotation as ignores * RD-7088: Try of removing code pieces * RD-7088: Revert code removal * RND-96 Add validations and error handling (#2474) * RND-96 Disabled helm wrapper modal (#2478) * Bump webpack from 5.73.0 to 5.76.0 (#2476) Bumps [webpack](https://github.com/webpack/webpack) from 5.73.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.73.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Norbert Kruk <[email protected]> * RD-6709 Removed snapshot endpoints from cookie-authenticated endpoints list (#2480) Co-authored-by: Jakub Madej <[email protected]> * RND-217: Upgraded jest related packages to the newest version (#2481) * RD-6711, RND-209 Seperate environments from services in Blueprints page (#2479) * RD-6711, RND-209 Seperate environments from servicrd in Blueprints page * replace fill with map * RD-4797 Bypass maintenance when getting user data (#2484) * RND-209 fix edit mode spec (#2487) * RD 5758 Migration of Events and Logs Widget (#2477) --------- Co-authored-by: bartosz-lewinski <[email protected]> * RD-6967: Align blueprint catalog action buttons (#2488) * RD-6967: Upated alignment of buttons * RD-6967: Extracted action buttons to an external file * RD-6967: Extracted styled components * RD-6967: Adjusted system tests * RD-6967: Simplified rendering conditions * RND-166, RND-167 - move "Map" , "Filter", "Bulk actions" above the list of the deployments in services & environments page page (#2483) * RND-166, RND-167 - move "Map" , "Filter", "Bulk actions" above the list of the deployments in services & environments page page * update styles * RD-5765 Migrate Blueprint Sources widget (#2467) * RD-5765 Migrate Blueprint Sources widget * Fix lint * Address review comment * Fix typo * update size-limit * update size-limit * fix check-types * Address review comment * Revert; address review comment; * deploymentId * size-limit * Fix check-types * size-limit * Change to camelCase * align children type * deploymentIdRefined --> rawDeploymentId * aligning loop argument types, or aligning timestamp type. Same applies to children * isEmptyWidgetData * fix rpm * deploymentIds * Change loop signature * fix check types * NonNullable * Allign types * remove export * fix types * fix types * fix types * fix types * discriminated union * fix types * remove children prop * use correct type for item * fix types * fix types * fix types * fix types * fix types * remove duplication * fix types * fix status * fix types * remove isDir * remove as * shorter assertion * remove if * null should be part of GetSourceBrowseBlueprintArchiveResponse; blueprintTree nullish * Fix types * tree?.isDir && tree.children[0].key * archiveTree && * RD-6967: Fixed buttons allignement (#2493) * RND-96 Remove HELM modal implementation from stage (#2492) * RND-218 Fix workflow parameters required indicator (#2485) * Use `default` property to check if workflow parameter is required * Add test for optional/required workflow parameters * RD-7117 Stage system tests failed on deployments_spec (#2496) * RD-7117 Stage system tests failed on deployments_spec * Add default value to parameter * RD-7116 Refactor Deployments View widget spec to use Cypress custom commands for setting widget configuration fields (#2500) * Use custom Cypress command for setting widget configuration dropdown field * Refactor Deployments View widget spec to use Cypress custom commands for setting widget configuration fields * RD-6316 Update Deployments View widget documentation (#2503) * Updated cloudify-ui-components (#2502) Co-authored-by: Jakub Madej <[email protected]> * RD-7117 Fix mocked deployment object in Deployments widget spec (#2501) * Fix mocked deployment object in Deployments widget spec * Fix `site_name` field type * RND-220: Modified way of selecting dropdown value (#2504) * RND-297 backend dockerfile: allow configuring port & protocol (#2506) Similar to setting the host, also allow setting the target port & proto via envvars. * RND-21 Presented suggested blueprints on "deploy on" functionality (#2499) * RND-21: Initialized switching mechanism for blueprint dropdown * RND-21: Added ability to fetch and display filtered blueprints * RND-21: Removed environment references * RND-21: Passed deployment capabilities to deploy modal * RND-21: Filtered blueprints * RND-21: Updated name of the components * RND-21: Adjusted dropdown translations * RND-21: Updated test scenario to cover newest functionality * RND-21: Adjusted failing system tests * RND-21: Removed unnecessary comments * RND-21: Shared common functionalities between custom dropdowns * RND-21: Adjusted system tests * Update test/cypress/integration/widgets/deployments_spec.ts Co-authored-by: Jakub Niezgoda <[email protected]> * RND-21: Addressed code review comments --------- Co-authored-by: Jakub Niezgoda <[email protected]> * RND-278 Sync widget docs (#2511) * RD-7133 Create Environment Adjustments (#2510) * RD-7133 adjustments for enviornments modal * update ui-components * "fix test - add ':'" * RND-102 Reuse git logic extracted to common-backend (#2508) * RD-7133 fix system test and refactor (#2513) * RD-7133 fix system test and refactor * remove unnecessary 'checkLabelPresence' * remove GET * RND-57: Disabled buttons when there are no blueprints in the system (#2509) * RND-57: Added ability to disable deployment button when there are no blueprints * RND-57: Added ability to disable environment button when there are no blueprints * RND-57: Updated disabling buttons condition * RND-57: Synchronized documentation * RND-57: Provided new test scenario * RND-57: Provided new test scenario * RND-57: Adjusted export statements * RND-57: Adjusted test scenarios * RND-57: Made stubbing requests more specific * Update test/cypress/integration/widgets/deployment_button_spec.ts Co-authored-by: Jakub Niezgoda <[email protected]> * Update widgets/deploymentButton/src/widget.tsx Co-authored-by: Jakub Niezgoda <[email protected]> * RND-57: Addressed code review comments * RND-57: Added ability to pass filterId to the search methods * RND-57: Removed unused peice of code --------- Co-authored-by: Jakub Niezgoda <[email protected]> * RND-104 Reuse DynamicTable from ui-common (#2515) * RND-145: Disabled selecting not common workflows in RunWorkflowModal (#2514) * RND-213: Implemented fetching, grouping and disabling workflow options * RND-213: Simplified code * RND-213: Simplified code * RND-213: Fixed sorting issue and simplified logic * RND-213: Introduced new test scenario * RND-213: Increased code robustness * Update app/widgets/common/deploymentsView/header/RunWorkflowModal.tsx Co-authored-by: kubama <[email protected]> --------- Co-authored-by: kubama <[email protected]> * remove language=json (#2520) * RND-311 Reuse features moved to cloudify-ui-components (#2522) * RND-359 System test fix (#2523) * RND-145: Adjusted system test scenario (#2525) * RND-422 Updated vm2 to fix audit failure (#2529) * RD-4589 Fix click event propagation prevention (#2530) * RD-5771 Migrate Resource Filter widget to TypeScript (#2531) * Bump vm2 from 3.9.15 to 3.9.16 in /backend (#2534) Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.15 to 3.9.16. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.15...3.9.16) --- updated-dependencies: - dependency-name: vm2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Norbert Kruk <[email protected]> * RD-6901 Improve dropdown option click (#2536) * RND-359 Extend fix for widgets adding (#2538) * RND-107 Create Execution Logs widget - part 1 (#2533) Execution Logs with basic functionality: - Showing only the last 50 items coming from /events endpoint, for selected execution_id - Marking error logs (detected by checking event type and log level) with custom style (red color text) - Long error messages are expandable (responsive solution = reacts on screen size adjustments) - For logs having error causes an icon opening details modal on click is presented Some common code used e.g. in Events/Logs widget was extracted to widgets common. * RND-146: Given ability to modify workflow parameters while running workflow (#2521) * RND-213: Implemented fetching, grouping and disabling workflow options * RND-213: Simplified code * RND-213: Simplified code * RND-213: Fixed sorting issue and simplified logic * RND-213: Introduced new test scenario * RND-213: Increased code robustness * RND-146: Synchronized modal header with number of filtered deployments * RND-146: Enhanced stored workflows state * RND-146: Presented workflow parameters list as form fields * RND-146: Filtered parameters which are supported * RND-146: Provided ability to submit form data * RND-146: Simplified operations on workflow parameters * RND-146: Initialized form with default parameters values * RND-146: Resolved issue with sequential state update * RND-146: Extracted utility files * RND-146: Reused types * RND-146: Simplified code * RND-146: Added TODOs * RND-146: Added logic of marking fields as required * RND-146: Updated message content * RND-146: Enhanced form validation * RND-146: Adjusted form initialization and validation * RND-146: Simplified code * RND-146: Updated form validation logic * RND-146: Introduced new test scenario * RND-146: Applied suggestions from code review * RND-146: Remobed bug related to unsupported parameter types * RND-146: Addressed code review suggestions * RND-146: Shortened mapping function * RND-146: Shared common type * RND-146: Simplified fields generation * RND-146: Removed unnecessary console log * RND-311 Disabled terraform wrapper (#2540) * RND-107 Create Execution Logs widget - part 2 (#2541) * Add "Show more logs" button * Add test * fix: backend/package.json & backend/package-lock.json to reduce vulnerabilities (#2542) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-VM2-5426093 Co-authored-by: snyk-bot <[email protected]> * RND-57: Adjusted way of filtering blueprints (#2544) * RND-57: Adjusted way of filtering blueprints * RND-57: Reused shared environment filter * RND-146: Snychronized documentation (#2545) * RND-163 view environments and services by clicking number in table (#2543) * RND-163 * extract drilldowntosubdeployments" * restore title * changeder renderDeploymentRow * revert changes * revert changes - p2 * revert changes p3 * add line * add test * change size limit * modify after CR * refactor codee * minor refactoring * modify renderDeploymentRow * minor fixes * title from translate * enhance test * improvment to test, name variable and styling * simplify transalte * improve variables names' * update styled-components selectors * RD-6965 hidden open in composer buttons when user doesnt have bluepri… (#2489) * RD-6965 hidden open in composer buttons when user doesnt have blueprint_upload permission * used composer link permission to figure out if user should have composer link --------- Co-authored-by: bartosz-lewinski <[email protected]> * RND-423 Upgraded `passport-saml` to v4 (#2532) * RND-163, RND-527 improve deplotments_view_spec (#2547) * improve test * remove only * RD-4589: Added test retries (#2548) * RD-7152 Add support for Resource Filter widget configuration in Cypress tests (#2551) * Add support for Resource Filter widget configuration in Cypress tests * Override Resource Filter widget configuration in Execution Logs widget test * RND-313 Reuse login page component extracted to cloudify-ui-components (#2546) * RND-163, RND-527 fix deployments_view_spec (#2552) * RND-163 * remove only and revert viewport * try with parents * Update test/cypress/integration/widgets/deployments_view_spec.ts Co-authored-by: kubama <[email protected]> * resolve prettier issue --------- Co-authored-by: kubama <[email protected]> * RD-7025 Add retries in run mode for auth_spec (#2554) * RD-6631 Add retries in run mode for `user_configuration_spec` (#2555) * Simplify user_configuration_spec * Add test retries to user_configuration_spec * Improve variable naming * RND-643 - Non-root users for stage containers (#2556) * RND-649 - Update non-root user for Stage containers (#2557) * RND-708 vm2 audit fix (#2560) * RND-533 Increased number of retries (#2562) * RND-360 Update getting started and blueprint examples' links [master] (#2516) * Update versions for 7.0 release * Remove unused schema files * RND-583 Improve redirects handling (#2564) * Allow only local redirects after login * Block HTML content on GET /external/content endpoint * Update tests * RD-6873 Migrated away from using translation acronyms (#2566) * RD-6873 Migrate away from using translation acronyms * RD-6873 Migrated rest of the codebase from using translation acronyms * RD-6873 Migrated away from exporting translation paths * Bump dottie from 2.0.2 to 2.0.4 in /backend (#2568) Bumps [dottie](https://github.com/mickhansen/dottie.js) from 2.0.2 to 2.0.4. - [Release notes](https://github.com/mickhansen/dottie.js/releases) - [Commits](mickhansen/dottie.js@v2.0.2...v2.0.4) --- updated-dependencies: - dependency-name: dottie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RND-887 Update Jest and types/Jest to 29.5.0 (#2570) * RND-887 - update jest to 29.5.0 * remove types from dependcies and leave only in optional deps * CYBL-2046 Fix data source in Deployment ID input field (#2573) * Use /searches/deployments endpoint in Deployment ID input to fetch IDs with provided constraints * Fix deployment inputs spec * fix: backend/package.json & backend/package-lock.json to reduce vulnerabilities (#2571) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SEMVER-3247795 Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Patrycja <[email protected]> * CYBL-2072 - Deployment Execution widget doesn't open execution's modal (#41) (#2581) * CYBL-2072 - Deployment Execution widget doesn't open execution's modal * Added test to make sure the Execution Parameters dialog is shown. --------- Co-authored-by: Perry Pellerino <[email protected]> * NE-2894 Fix failing step "test backend" (#2588) Co-authored-by: Patrycja <[email protected]> * NE-8969 Move executions widget backend to regular stage backend (#2589) * add maps token to stage-backend (#2590) * [NE-5433-6171]Replace vm2 package with isolated-vm for backendwidget (#2587) * replace vm2 with isolated-vm to fix security-vulnerability * update script upload from backendWidget add temp fix to remove executions backend ts * NE-6171 NE-6173: added utility functions for manager and request API calls * Adding gcc 7 installation. * Adding gcc 7 installation. * NE-6171 NE-6173 sandbox utility functions - added logger functions - updated utility function names - accepting service name as parameter * handle promise rejection from registrator * fixing lint errors * NE-6171 audit fix * Revert "NE-6171 audit fix" This reverts commit 4973e7f. * remove vm2 server update testWigetBackend.zp * NE-6171 NE-6173 sandbox utility functions - updated parameters - accpets request options stringified object so as to accomodate body, headers, and params together * NE-5433 utilty function and minor fixes: - fixed types - updated test widget archive - removed unnecessary imports - added tests for sandbox servie * NE-5433 type casting and other minor fixes --------- Co-authored-by: Ashish Ghone <[email protected]> Co-authored-by: Bartosz Kosciug <[email protected]> * NE-9891 Fix security issues reported by NPM audit on production dependencies (#2592) * Fix frontend security issues reported by npm audit * Fix backend security issues reported by npm audit * NE-5433 IVM updated src file for testWidgetBackend.zip (#2591) * Tune spec. for isolated-vm package. (#2595) * NE-5433 Adjusted tests scenario for system test failure (#2597) * NE-5433 Adjusted tests scenario * NE-5433 Updated example widgets archive filenames --------- Co-authored-by: Norbert Kruk <[email protected]> * NE-6680 Use `manylinux` as fallback distribution in plugins catalog (#140) (#2598) * Add `manylinux` to fallback distribution list in `getWagon` function * Modernize `getYamlUrl` and `getWagon` functions * Add tests for `PluginUtils` functions * Fix `file_size` type in `PluginWagonUrl` type Co-authored-by: Kuba Niezgoda <[email protected]> * run npm install to clean package-lock * run npm install on backend to clean package-lock * update docs - Readme of deploymentsView widget --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: opencm <[email protected]> Co-authored-by: kubama <[email protected]> Co-authored-by: Norbert Kruk <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Madej <[email protected]> Co-authored-by: Jakub Niezgoda <[email protected]> Co-authored-by: Bartosz Lewiński <[email protected]> Co-authored-by: bartosz-lewinski <[email protected]> Co-authored-by: Leon Gilyadov <[email protected]> Co-authored-by: Łukasz Maksymczuk <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Adrian Polanczyk <[email protected]> Co-authored-by: PerryP <[email protected]> Co-authored-by: Perry Pellerino <[email protected]> Co-authored-by: Yuval Rapaport <[email protected]> Co-authored-by: Jyoti siddareddi <[email protected]> Co-authored-by: Ashish Ghone <[email protected]> Co-authored-by: Bartosz Kosciug <[email protected]> Co-authored-by: devadgh1 <[email protected]> Co-authored-by: bartoszkosciug <[email protected]> Co-authored-by: Norbert Kruk <[email protected]> Co-authored-by: Kuba Niezgoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded
passport-samlto v4Screenshots / Videos
Checklist
Tests
Documentation
N/A