翻译4.4.2 webhook for core types 章节 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy succeeded Built with commit 45af7fa |
|
/review |
hzliangbin
suggested changes
Aug 13, 2020
| for core types, you have to use the library from controller-runtime to handle it. | ||
| There is an [example](https://github.com/kubernetes-sigs/controller-runtime/tree/master/examples/builtins) | ||
| in controller-runtime. | ||
| 为 CRD 构建准入 webhook 非常容易，这在 CronJob 教程中已经介绍过了。由于 kubebuilder 不支持核心类型的 webhook 搭建，您必须使用 controller-runtime 的库来处理它。这里可以参考 controller-runtime 的一个 [示例](https://github.com/kubernetes-sigs/controller-runtime/tree/master/examples/builtins)。 |
There was a problem hiding this comment.
scaffolding有自动生成框架代码的意思，这里翻译不支持搭建，容易有误解。
There was a problem hiding this comment.
HI 我修改成这样了 由于 kubebuilder 不支持核心类型的 webhook 自动生成 。 你觉得如何呢？
|
@hzliangbin 这个PR 可以merge吗？ |
hzliangbin
approved these changes
Aug 17, 2020
majinghe
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: 72
[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure