翻译4.5.4 Webhook章节 #182
Merged
翻译4.5.4 Webhook章节 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy succeeded Built with commit 7c9c123 |
|
/reference/markers/webhook.md #93 |
|
/review |
hzliangbin
suggested changes
Aug 13, 2020
| Use these to keep the description of your webhooks close to the code that | ||
| implements them. | ||
| 这些标记描述了[webhook配置](../webhook-overview.md)如何生成。 | ||
| 使用这些使您的 webhook 描述与实现它们的代码保持一致。 | ||
|
|
||
| {{#markerdocs Webhook}} |
There was a problem hiding this comment.
注意下看下预览界面，引用的webhook-overview.md部分是否需要翻译？
majinghe
reviewed
Aug 14, 2020
| Use these to keep the description of your webhooks close to the code that | ||
| implements them. | ||
| 这些标记描述了[webhook配置](../webhook-overview.md)如何生成。 | ||
| 使用这些使您的 webhook 描述与实现它们的代码保持一致。 |
|
@lhb008 这个修改完了，你看下能 merge 了不 |
|
/LGTM |
majinghe
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cloudnativeto/kubebuilder/issues/
[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure