-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
翻译4.5 Markers for Config/Code Generation #188
Conversation
Deploy succeeded Built with commit 1b068cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/review
docs/book/src/reference/markers.md
Outdated
separated from the name by a colon, and latter arguments are | ||
comma-separated. Order of arguments doesn't matter. Some arguments may | ||
be optional. | ||
(`+kubebuilder:printcolumn:JSONPath=".status.replicas",name=Replicas,type=string`):多选项标记使用一个或多个命名参数。第一个参数与名称之间用冒号隔开,而后面的参数使用隔开。参数的顺序没有关系。有些参数是可选的。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后面的参数使用逗号隔开
,这里漏掉了 逗号 吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯 ,是的。我改一下。
docs/book/src/reference/markers.md
Outdated
`map[string]interface{}`). A map is surrounded by curly braces (`{}`), | ||
each key and value is separated by a colon (`:`), and each key-value | ||
pair is separated by a comma: | ||
Maps 是用键和任意类型的值(有效地`map[string]interface{}`)来指定的。一个 map 是由大括号(`{}`)包围起来的,每一个键和每一个值是用冒号(`:`)隔开的,每一个键值对是由逗号隔开的。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里Maps 是用键和任意类型的值
的 键
,是不是明确下 字符类型的键
会好一点呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以。
@luffy110 已修改。 |
OK, 我觉得 没什么其他问题了。 |
ref: #78
[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure