Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

翻译 4.5.2 章节 #189

Merged
merged 2 commits into from
Aug 17, 2020
Merged

翻译 4.5.2 章节 #189

merged 2 commits into from
Aug 17, 2020

Conversation

skyshang1
Copy link

ref: https://github.com/cloudnativeto/kubebuilder/issues/

[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@netlify
Copy link

netlify bot commented Aug 15, 2020

Deploy succeeded

Built with commit d170db2

https://deploy-preview-189--cnc-kubebuilder.netlify.app

@majinghe
Copy link

/review

@@ -3,7 +3,8 @@
These markers modify how the CRD validation schema is produced for the
types and fields they modify. Each corresponds roughly to an OpenAPI/JSON
schema option.
这些标记修改了如何为其修改的类型和字段生成 CRD 验证框架。每个标记大致对应一个 OpenAPI/JSON 模式选项.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

结尾应该是个中文句号。


See [Generating CRDs](/reference/generating-crd.md) for examples.
有关示例,请参见[Generate CRDs](/reference/generating-crd.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个Generating CRDs。可以直接翻译出来,生成 CRDs。

@majinghe
Copy link

@skyshang1 提了两个建议,可以参考一下。🙏

@skyshang1
Copy link
Author

@skyshang1 提了两个建议,可以参考一下。🙏

好的,我修改下

@skyshang1
Copy link
Author

@lhb008 修改完了,你再 review 下

@majinghe
Copy link

/LGTM

@mergify mergify bot merged commit aad0d9c into cloudnativeto:zh Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants