fixup! Add enable_parent_task_queue_for_child_workflows service option

cludden · Aug 28, 2024 · e82835b · e82835b
1 parent f92507e
commit e82835b
Show file tree

Hide file tree

Showing 42 changed files with 8,953 additions and 492 deletions.
diff --git a/buf.yaml b/buf.yaml
@@ -11,6 +11,7 @@ modules:
     name: buf.build/cludden/protoc-gen-go-temporal
   - path: test/expression/proto
   - path: test/option/proto
+  - path: test/patch/proto
   - path: test/simple/proto
   - path: test/xnserr/proto
 deps:

diff --git a/docs/docs/configuration/service.mdx b/docs/docs/configuration/service.mdx
@@ -18,21 +18,6 @@ service Example {
 
 ## Options
 
-### enable_parent_task_queue_for_child_workflows
-
-`bool`
-
-Use parent workflow task queue for child workflows.
-
-```protobuf
-service Example {
-  option (temporal.v1.service) = {
-    task_queue: 'example-v1'
-    enable_parent_task_queue_for_child_workflows: true
-  };
-}
-```
-
 ### patches
 
 [[]temporal.v1.Patch](https://buf.build/cludden/protoc-gen-go-temporal/docs/main:temporal.v1#temporal.v1.Patch)
@@ -43,10 +28,10 @@ Controls how a particular [Patch](/docs/guides/patches) is implemented in genera
 service Example {
   option (temporal.v1.service) = {
     patches: [
-      { version: PV_62, mode: PV_REMOVED },
-      { version: PV_63, mode: PV_MARKER },
-      { version: PV_64, mode: PV_ENABLED },
-      { version: PV_65, mode: PV_DISABLED }
+      { version: PV_62, mode: PVM_REMOVED },
+      { version: PV_63, mode: PVM_MARKER },
+      { version: PV_64, mode: PVM_ENABLED },
+      { version: PV_65, mode: PVM_DISABLED }
     ]
   };
 }

diff --git a/docs/docs/guides/patches.mdx b/docs/docs/guides/patches.mdx
@@ -55,3 +55,9 @@ By default, patches are introduced in `PVM_ENABLED` mode, where both the patch c
 [protoc-gen-go-temporal#64](https://github.com/cludden/protoc-gen-go-temporal/issues/64)
 
 Wraps expression evaluation in local activities within workflow contexts (i.e. child workflow helpers). This prevents non-determinism errors when an expression contains non-deterministic statements and is evaluated in a long-running workflow that is rescheduled onto a different worker.
+
+### PV_77 Use Parent Task Queue
+
+[protoc-gen-go-temporal#77](https://github.com/cludden/protoc-gen-go-temporal/pulls/77)
+
+Defaults to using to the parent workflow task queue for child workflows and activities when the default task queue for the parent workflow matches the default task queue of the child workflow or activity.
diff --git a/gen/example/helloworld/v1/example_temporal.pb.go b/gen/example/helloworld/v1/example_temporal.pb.go
diff --git a/gen/example/helloworld/v1/helloworldv1xns/example_xns_temporal.pb.go b/gen/example/helloworld/v1/helloworldv1xns/example_xns_temporal.pb.go
diff --git a/gen/example/mutex/v1/mutex_temporal.pb.go b/gen/example/mutex/v1/mutex_temporal.pb.go
diff --git a/gen/example/mutex/v1/mutexv1xns/mutex_xns_temporal.pb.go b/gen/example/mutex/v1/mutexv1xns/mutex_xns_temporal.pb.go
diff --git a/gen/example/schedule/v1/schedule_temporal.pb.go b/gen/example/schedule/v1/schedule_temporal.pb.go
diff --git a/gen/example/schedule/v1/schedulev1xns/schedule_xns_temporal.pb.go b/gen/example/schedule/v1/schedulev1xns/schedule_xns_temporal.pb.go
diff --git a/gen/example/searchattributes/v1/searchattributes_temporal.pb.go b/gen/example/searchattributes/v1/searchattributes_temporal.pb.go
diff --git a/gen/example/searchattributes/v1/searchattributesv1xns/searchattributes_xns_temporal.pb.go b/gen/example/searchattributes/v1/searchattributesv1xns/searchattributes_xns_temporal.pb.go
diff --git a/gen/example/updatabletimer/v1/updatabletimer_temporal.pb.go b/gen/example/updatabletimer/v1/updatabletimer_temporal.pb.go
diff --git a/gen/example/updatabletimer/v1/updatabletimerv1xns/updatabletimer_xns_temporal.pb.go b/gen/example/updatabletimer/v1/updatabletimerv1xns/updatabletimer_xns_temporal.pb.go