Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap expression evaluation in local activity inside workflow contexts #65

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

cludden
Copy link
Owner

@cludden cludden commented Apr 24, 2024

What has changed

  • introduces fix for potential non-determinism errors evaluating expressions inside child workflow helpers by wrapping evaluation in local activities.
  • introduces completed_fix_versions plugin, service option allowing consumers to remove workflow versioning once fix has been rolled out and old workflow histories are closed and no longer at risk of being replayed

closes: #64

@cludden cludden force-pushed the cludden/child-workflow-id-local-activity branch from 8a6d38e to 6ee2df9 Compare April 24, 2024 23:29
@cludden cludden marked this pull request as ready for review April 24, 2024 23:31
@cludden cludden force-pushed the cludden/child-workflow-id-local-activity branch from 6ee2df9 to 4575e9e Compare April 25, 2024 03:16
@cludden cludden force-pushed the cludden/child-workflow-id-local-activity branch from 4575e9e to 0ffc084 Compare April 28, 2024 22:24
@cludden cludden merged commit 96aa1f8 into main Apr 29, 2024
1 check passed
@cludden cludden deleted the cludden/child-workflow-id-local-activity branch April 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap expression evaluation in local activity in workflow contexts
2 participants