Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bundleReference to the claim specification #31

Merged
merged 2 commits into from
Dec 19, 2019
Merged

add bundleReference to the claim specification #31

merged 2 commits into from
Dec 19, 2019

Conversation

adamreese
Copy link
Contributor

glyn
glyn reviewed Dec 12, 2019
View reviewed changes
src/claim.rs Show resolved Hide resolved
glyn
glyn reviewed Dec 12, 2019
View reviewed changes
src/claim.rs Outdated Show resolved Hide resolved
technosophos
technosophos approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, with Glyn's minor doc changes, this is totally LGTM. Thanks!

glyn
glyn suggested changes Dec 12, 2019
View reviewed changes
Copy link

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my remaining suggestion should be applied for consistency with the spec.

@adamreese adamreese requested a review from glyn December 19, 2019 00:01
@radu-matei
Copy link
Member

I think this needs a rebase, then we can merge.
Thanks!

@technosophos technosophos merged commit 0dde62a into cnabio:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-matei radu-matei radu-matei approved these changes

@glyn glyn glyn approved these changes

@technosophos technosophos technosophos approved these changes

@jlegrone jlegrone Awaiting requested review from jlegrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamreese @radu-matei @technosophos @glyn