-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BUILD_ONLY_PYTHON_INTERFACE option #658
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will review it as soon as I can
@nim65s I think your change are good. I will try to create local conda-package to check if it's working well. The only issue I see is in most of our project, the root CMakeLists will search for all dependencies. If we don't want some dependencies in the Python build, we will have to add guards around add_dependencies to avoid searching for them in the Python only build. I was thinking to an alternative approach: turning the python/CMakeLists.txt file into a standalone project. So user that only want the python binding can go on this sub directory, run cmake and build it. |
Yes, I'm planninng to do test packaging on robotpkg / cmeel / nix before marking this as ready.
do you have an example in mind ? For eg. boost, we'll got this transitively with the c++ package anyways. For eg. eigen, well, I don't really see the issue.
I like the idea, this should probably be tried too. It sounds like it will require heavy changes in the cmake, the docs and the tests though. |
You right for the dependencies, it should be a non issue. The only issue is the guard added to avoid building the main project. I have tried to create a separate sub project in this PR : #660 |
Here is an example for jrl-umi3218/jrl-cmakemodules#745
I'm testing this with that script
NB: the nix commit is not meant to stay in the final version of this PR.