-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on telemetry collection #19131
base: main
Are you sure you want to change the base?
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
54425c1
to
b8f6601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some broken formatting here. TLDR is:
- No
<p>
tags inside table cells - Replace all
<pre>
tags with<code>
tags
(Unless I missed a good reason for using either tag)
thanks for the review @taroface !!! there's no good reason why i used any of the specific tags in this PR so i've updated everything based on your comments! I think this is RFAL |
ps Ryan idk if you write a lot of {H,X}ML but i have used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 nits, I wish I understood why the code blocks have extra spaces above and sometimes below, but oh well!
<code> | ||
"licenseType": "Enterprise" | ||
</code> | ||
See also: Locality, Hardware Info, OS Info, Build Info, and Topology Info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a <br>
as this is bleeding out of the code
"provider": "gcp", | ||
"instanceClass": "n2-standard-16" | ||
</code> | ||
See also CPU Info and Memory Info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as below on adding a <br>
See also CPU Info and Memory Info | |
See also: CPU Info and Memory Info |
Fixes DOC-11051