-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the restore backups across major version docs for innovation releases #19375
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
d6b8202
to
538fd2e
Compare
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! i was surprised that the v24.3 and v25.1 docs referred to a "v24.1.x format", but i assume that is referring to some internals of how backups work that is beyond my ken
@@ -11,23 +11,29 @@ This page describes the support Cockroach Labs provides for restoring backups ac | |||
- [Support for long-term backup archival](#support-for-long-term-backup-archival) | |||
|
|||
{{site.data.alerts.callout_info}} | |||
Since CockroachDB considers the cluster version when running a backup, this page refers to versions in a "v22.2.x" format. For example, both v22.2.8 and v22.2.14 are considered as v22.2 clusters for backup purposes. | |||
Since CockroachDB considers the cluster version when running a backup, this page refers to versions in a "v24.1.x" format. For example, both v24.1.8 and v24.1.12 are considered as v24.1 clusters for backup purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, v25.1 docs still refer to a "v24.1.x" format? this has had technical review so must be correct, but as a general reader this stood out to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried out the liquid variable for page version with this format, and it works — so I've updated this first callout in each version's page with this so that it will automatically update. I haven't updated the table with this as it'll be hard to control as we progress in versions and the restore pattern is specific.
61fb57c
to
06898a3
Compare
06898a3
to
9f65113
Compare
Fixes DOC-11980
This PR updates the Restoring Backups Across Versions page to account for innovation releases.
Innovation releases were introduced in v24.2, so the changes have been added to v24.1+ since the policy is that users can restore to the same major version, or one above — v24.1 clusters can upgrade to v24.3 (skipping the first v24.2 innovation release).