-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features requiring finalization to v25.1 major release notes #19379
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spilchen should ALTER COLUMN TYPE be in this list too?
@DrewKimball should DO
statements be here?
@fqazi anything we should mention about memo staleness or waiting for initial versions of descs here?
@dt Those are internal to the product, and shouldn't have any visible external changes. |
Yes, I think it should. ALTER COLUMN TYPE existed before version 25.1, but it was in experimental mode and not ready for GA. Once 25.1 is finalized, you can use the new logic in the declarative schema changer to support this operation. |
I think ALTER COLUMN TYPE should be included in the list of features that require finalization. Will that be covered in a separate PR? |
@spilchen Yes, @rmloveland will be adding this soon. I'd merged this before seeing your comment, then asked Rich to cover it once I noticed. Thanks. |
Regular DO statements aren't persisted, so don't need a version check. A DO statement within a routine does require the finalized version, though. |
DOC-12267