Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features requiring finalization to v25.1 major release notes #19379

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

mikeCRL
Copy link
Contributor

@mikeCRL mikeCRL commented Feb 14, 2025

Copy link

Files changed:

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 22ef22d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67b617796447ad00081841d4

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 22ef22d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67b617792e0419000737b4bc

@mikeCRL mikeCRL changed the title Add features requiring finalization Add features requiring finalization to v25.1 major release notes Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Netlify Preview

Name Link
🔨 Latest commit 22ef22d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67b617799bc9f100085a6223
😎 Deploy Preview https://deploy-preview-19379--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikeCRL mikeCRL requested review from dt and nvanbenschoten February 14, 2025 20:59
@mikeCRL mikeCRL marked this pull request as ready for review February 14, 2025 21:00
Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spilchen should ALTER COLUMN TYPE be in this list too?
@DrewKimball should DO statements be here?
@fqazi anything we should mention about memo staleness or waiting for initial versions of descs here?

@fqazi
Copy link

fqazi commented Feb 19, 2025

@dt Those are internal to the product, and shouldn't have any visible external changes.

@spilchen
Copy link

@spilchen should ALTER COLUMN TYPE be in this list too?

Yes, I think it should. ALTER COLUMN TYPE existed before version 25.1, but it was in experimental mode and not ready for GA. Once 25.1 is finalized, you can use the new logic in the declarative schema changer to support this operation.

@mikeCRL mikeCRL merged commit 8ac422a into main Feb 19, 2025
6 checks passed
@mikeCRL mikeCRL deleted the 25.1-upgrade-finalization branch February 19, 2025 18:05
@spilchen
Copy link

I think ALTER COLUMN TYPE should be included in the list of features that require finalization. Will that be covered in a separate PR?

@mikeCRL
Copy link
Contributor Author

mikeCRL commented Feb 20, 2025

@spilchen Yes, @rmloveland will be adding this soon. I'd merged this before seeing your comment, then asked Rich to cover it once I noticed. Thanks.

@DrewKimball
Copy link

@DrewKimball should DO statements be here?

Regular DO statements aren't persisted, so don't need a version check. A DO statement within a routine does require the finalized version, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants