Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle student & coach event emailing as separate #2127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnclmorais
Copy link
Contributor

@gnclmorais gnclmorais commented Oct 25, 2024

Send them both in the background, separately. This should help with the timeouts we have sometimes on Heroku, I hope. Thoughts @matyikriszta? Do you think we could spin up a review-app of this on Heroku or something, and trigger test emails?

In any case, I revisited #1750 and got it back to shape. ✨ That one should definitely help in sending less emails.

Send them both in the background, separately. This should help with
the timeouts we have sometimes on Heroku.
@matyikriszta
Copy link
Contributor

matyikriszta commented Oct 26, 2024

@gnclmorais we currently can't set up Review apps, we'd never set that feature up on Heroku and in the app and since we are trying to move away from Heroku I do not want to invest time in it. We could potentially test on staging, I do wonder if we have enough seed data to meaningfully test this feature, we'd have to have thousands of members subscribed to a chapter to really be able to test it. I think this should help already, one other thing we could do is set the coach emails to deliver_later. Not sure how this works together with the handle_asynchronously method. Coach spots do not fill up as fast as student spots so I think it's not a big issue if everyone doesn't get the email at about the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants