Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new minio storage service #516

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: new minio storage service #516

merged 1 commit into from
Feb 20, 2025

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Feb 19, 2025

We were running into a S3Error in Sentry when we enabled the new Minio storage backend and this is the fix for that. The reason we were passing these headers in the first place was due to the docs here.

The only difference between the requests was that this header was being set so I removed it to see if it would fix the error in staging and it did.

@joseph-sentry joseph-sentry marked this pull request as draft February 19, 2025 16:01
@joseph-sentry joseph-sentry marked this pull request as ready for review February 20, 2025 14:24
@joseph-sentry joseph-sentry requested a review from a team February 20, 2025 14:24
@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 12f2cec Feb 20, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-new-minio branch February 20, 2025 14:38
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (88ced51) to head (4277c68).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   90.50%   89.92%   -0.58%     
==========================================
  Files         463      324     -139     
  Lines       13275     8989    -4286     
  Branches     2116     1585     -531     
==========================================
- Hits        12014     8083    -3931     
+ Misses       1140      845     -295     
+ Partials      121       61      -60     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants