Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using a diff when tracking source dates #2521

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

worksofliam
Copy link
Contributor

Changes

Removes the ability to configure which mode will be used to track source date changes, and we now default to diff, which tracks changes based on the previous save of the file.

No functional changes here, only UX changes. Documentation may need to be updated after merge.

How to test this PR

Examples:

  1. Enable source dates, gutter optional but nice to have on
  2. Make changes to a file (optionally see the gutter update)
  3. Save the file and ensure all the source dates aren't set to today and only the changed lines are updated.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

Copy link
Contributor

github-actions bot commented Feb 19, 2025

👋 A new build is available for this PR based on 1b6a205.

@worksofliam worksofliam changed the title Change/remove_edit_mode_source_dates Default to using a diff when tracking source dates Feb 19, 2025
Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments + we should update the description for code-for-ibmi.showDateSearchButton:

If enabled, will show the 'Date search' button in the status bar when source dates with diff mode is enabled.

Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and it works as expected now!

Going back to my previous comment, shouldn't we drop the "when source dates with diff mode is enabled." for showDateSearchButton?

@worksofliam worksofliam temporarily deployed to testing_environment February 26, 2025 19:56 — with GitHub Actions Inactive
@worksofliam
Copy link
Contributor Author

@SanjulaGanepola I am following now. I removed the showDateSearchButton config option.

@SanjulaGanepola
Copy link
Member

I was thinking just drop that part of the description, but your completely right in that we don't need that option all together. Looks good!

@worksofliam worksofliam merged commit b9b903e into master Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants