-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to using a diff when tracking source dates #2521
Conversation
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 1b6a205. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments + we should update the description for code-for-ibmi.showDateSearchButton
:
If enabled, will show the 'Date search' button in the status bar when source dates with diff mode is enabled.
Signed-off-by: worksofliam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and it works as expected now!
Going back to my previous comment, shouldn't we drop the "when source dates with diff mode is enabled." for showDateSearchButton
?
Signed-off-by: worksofliam <[email protected]>
@SanjulaGanepola I am following now. I removed the |
I was thinking just drop that part of the description, but your completely right in that we don't need that option all together. Looks good! |
Changes
Removes the ability to configure which mode will be used to track source date changes, and we now default to
diff
, which tracks changes based on the previous save of the file.No functional changes here, only UX changes. Documentation may need to be updated after merge.
How to test this PR
Examples:
Checklist
console.log
s I added