Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass source download fails on zero record members #2513 #2526

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mass source download fails on zero record members #2513 #2526

wants to merge 3 commits into from
+7 −8

Conversation

wimjongman
Copy link
Contributor

@wimjongman wimjongman commented Feb 21, 2025 •
edited
Loading

How to test this PR

  1. Create an empty member in a sourcefile
  2. Open VSCode, find the sourcefile and Select 'Download'
  3. Empty members are downloaded.

@wimjongman wimjongman marked this pull request as draft February 21, 2025 18:27
@worksofliam
Copy link
Contributor

Before this can be merged, #2525 needs to be merged.

Also, for your issue of Issues with resolving Component, try deleting the .json files in the tests directory before running the tests.

@wimjongman wimjongman mentioned this pull request Feb 21, 2025
Open
@wimjongman
Copy link
Contributor Author

Also, for your issue of Issues with resolving Component, try deleting the .json files in the tests directory before running the tests.

Yes, when I throw away these files the I get three errors.

image

When I leave them I get 4 errors extra:

image

image

image

@worksofliam
Copy link
Contributor

@wimjongman I actually suggest you build this PR on top of #2525, which has some fixes to component install states.

@wimjongman
Copy link
Contributor Author

Ok, I will wait on #2525

@worksofliam
Copy link
Contributor

@wimjongman That PR was merged. Please update this branch. Thanks!

@wimjongman wimjongman force-pushed the Mass-source-download-fails-on-zero-record-members-#2513 branch from 21ec0bf to d3a5e0a Compare February 25, 2025 13:31
@wimjongman wimjongman temporarily deployed to testing_environment February 25, 2025 13:31 — with GitHub Actions Inactive
@wimjongman wimjongman temporarily deployed to testing_environment February 26, 2025 09:14 — with GitHub Actions Inactive
@wimjongman wimjongman force-pushed the Mass-source-download-fails-on-zero-record-members-#2513 branch from de66f12 to ef302f6 Compare February 26, 2025 16:47
@wimjongman wimjongman marked this pull request as ready for review February 26, 2025 16:48
@wimjongman wimjongman force-pushed the Mass-source-download-fails-on-zero-record-members-#2513 branch from ef302f6 to 398dcee Compare February 26, 2025 16:52
@wimjongman
Copy link
Contributor Author

@worksofliam this now works as a charm. See the commit message for details.

@wimjongman
Mass source download fails on zero record members codefori#2513
8548f01 
When trying to copy an empty member to an already existing member
the system issues CPF2869.

When the empty member is copied to a new member, the message is
not send and the transaction continues.

The fix is to use the member name for the temporary member
and not reuse the existing 'TEMPMEMBER' member.

This also fixes:
Strange dialog button when downloading members codefori#2527
@worksofliam worksofliam self-requested a review February 26, 2025 17:01
@wimjongman wimjongman force-pushed the Mass-source-download-fails-on-zero-record-members-#2513 branch from 398dcee to 8548f01 Compare February 26, 2025 17:01
This was linked to issues Feb 27, 2025
Strange dialog button when downloading members #2527
Open
Mass source download fails on zero record memebers #2513
Open
@worksofliam
Copy link
Contributor

@wimjongman I should be getting to this tomorrow. I will likely merge, but I just realized when looking at these changes that this logic is happening in the UI, and in the future should be moved to the IBMiContent class, and then we could write a test case or two for it!

@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Feb 27, 2025
@wimjongman
Copy link
Contributor Author

Yes sounds good. I will take a look at it after the merge. I wanted to make a test but as you said, the meat is in the UI. It should not be too hard to refactor this part.

@wimjongman
Copy link
Contributor Author

@worksofliam I merged again with master. Let me know if you have doubts merging this.

@worksofliam
Copy link
Contributor

@wimjongman totslly my bad on the schedule. I had to take off Friday so I will get to it in the next few days.

This is the last PR before we release 2.15.0, so it's important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange dialog button when downloading members Mass source download fails on zero record memebers
2 participants
@wimjongman @worksofliam