Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate aspInfo getter in preparation for IBMi.getAllIAsps in v3.0.0 #2533

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Deprecate aspInfo getter in preparation for IBMi.getAllIAsps in v3.0.0 #2533

merged 1 commit into from
Feb 28, 2025
+13 −0

Conversation

worksofliam
Copy link
Contributor

Changes

aspInfo was removed and replaced by iAspInfo, but of course, aspInfo was public and is used in the database extension.

For 2.15.0 compatability, and the time period to allow extensions to change, I have added it back in but marked as deprecated.

How to test this PR

Examples:

Test editing an SQL job in the database extension under the following versions of vscode-ibmi:

  • production release 2.14.5: works
  • pre-release/master: error due to aspInfo missing
  • this branch/PR: works

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam temporarily deployed to testing_environment February 27, 2025 04:00 — with GitHub Actions Inactive
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 A new build is available for this PR based on a5658ce.

SanjulaGanepola
SanjulaGanepola approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing an SQL job works as expected now. Good catch

@worksofliam worksofliam merged commit f87574e into master Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjulaGanepola SanjulaGanepola SanjulaGanepola approved these changes

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

@julesyan julesyan Awaiting requested review from julesyan

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @SanjulaGanepola