Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track last login, and joining time for register and login routes #110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Track last login, and joining time for register and login routes #110

wants to merge 2 commits into from

Conversation

Vinayak-Anand
Copy link
Contributor

Track last login, and joining time for register and login routes. This PR closes #107

@Vinayak-Anand Vinayak-Anand added enhancement New feature or request backend labels May 20, 2024
@Vinayak-Anand Vinayak-Anand requested a review from aahnik May 20, 2024 13:47
@Vinayak-Anand Vinayak-Anand self-assigned this May 20, 2024
@aahnik
Copy link
Contributor

aahnik commented May 20, 2024 •
edited
Loading

@Vinayak-Anand, commit messages should follow this convention:

"[backend] ... your work done.."

@aahnik
Copy link
Contributor

aahnik commented May 20, 2024

You can git reset --soft HEAD~1 to undo your commit. Your code will be preserved, but the commit will be erased from history!

Then after making all the required changes, you may do git push -f (force push). If you don't force push, there will be errors as your local commit, and the commit in GitHub are different.

@aahnik aahnik marked this pull request as draft May 20, 2024 14:52
@Vinayak-Anand Vinayak-Anand force-pushed the vinayak-lastlogin-joiningtime branch from 22d8fa1 to 490105c Compare May 20, 2024 15:33
@Vinayak-Anand Vinayak-Anand force-pushed the vinayak-lastlogin-joiningtime branch from 490105c to b855ad2 Compare May 20, 2024 15:43
@Vinayak-Anand Vinayak-Anand requested review from Suvansarkar, virinci and SahooBishwajeet and removed request for virinci and SahooBishwajeet May 20, 2024 15:48
@aahnik aahnik marked this pull request as ready for review May 24, 2024 02:33
aahnik
aahnik approved these changes May 24, 2024
View reviewed changes
server/src/auth/auth.service.ts Outdated Show resolved Hide resolved
server/src/users/users.service.ts Outdated Show resolved Hide resolved
@aahnik aahnik force-pushed the vinayak-lastlogin-joiningtime branch from 34ef46e to 5d226d2 Compare May 24, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aahnik aahnik aahnik approved these changes

@Suvansarkar Suvansarkar Awaiting requested review from Suvansarkar

At least 2 approving reviews are required to merge this pull request.

Assignees

@Vinayak-Anand Vinayak-Anand

Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track last login, and joining time for register and login routes in auth
2 participants
@Vinayak-Anand @aahnik