Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send additional information about the page in the email #78

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

Send additional information about the page in the email #78

wants to merge 59 commits into from

Conversation

JeffersonBledsoe
Copy link
Member

Blocked by #37

This PR allows including additional information in the email that isn't a form. The information allowed to be included is:

  • The date the form was submitted
  • The time the form was submitted
  • The URL of the form submission
  • The title of the page the form was submitted from

## Todo

  • Add the same support to the data saving feature

JeffersonBledsoe and others added 30 commits September 22, 2023 01:53
@JeffersonBledsoe
Add class for 'Fields' to simplify custom logic and use it for filter…
c458ee2 
…_parameters
@JeffersonBledsoe
Fix non-required fields
d6aa386
@JeffersonBledsoe
Fix reading incorrect internal value
17697d8
@JeffersonBledsoe
Fix values not displayign
b9bb05f
@JeffersonBledsoe
Use @Property for 'value'
3c45a3a
@JeffersonBledsoe
Fix some existing behaviours
70a17f1
@JeffersonBledsoe
Add test for custom_field_id
9bf7879
@JeffersonBledsoe
Fix custom field ID
624170d
@JeffersonBledsoe
Fix inconsistent use of field_id in requess
3ea20ae
@JeffersonBledsoe
Restore support for falling back to field_id if label doesn't exist
b3ca7da
@JeffersonBledsoe
Fix data storing
e821e3f
@JeffersonBledsoe
Fix custom_field_id in data export
cd8e9bb
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
bd40e5c
@JeffersonBledsoe
Add tests for display values
e1994e0
@JeffersonBledsoe
Fix catalog using display value for storage
b5c75da
@JeffersonBledsoe
Fix XML using external value
f2ff588
@JeffersonBledsoe
Update frontend field name
2cf29d3
@JeffersonBledsoe
Test fix
810d675
@JeffersonBledsoe
Readme
5524684
@JeffersonBledsoe
Typo fix
ac749fb
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
262fce7 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
@JeffersonBledsoe
Add test for custom field ID and ensuring it isn't used in emails
30adf28
@JeffersonBledsoe
Fix using field_id in XML
47ede0b
@JeffersonBledsoe
Remove upgrades and test files from coverage
3785922
@JeffersonBledsoe
Improve tests for sending and storing custom fields
adb24a4
@JeffersonBledsoe
Fix for storing CSVs
c778d90
@JeffersonBledsoe @djay
Update README.rst
f503de7 
Co-authored-by: Dylan Jay <[email protected]>
Make fields API clearer
bcd03c3
Further clarify field API
22f8a9a
Improve test coverage
6a21647
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
98276f5
@JeffersonBledsoe
Try to integrate new email validation into fields
efeb8b8
@JeffersonBledsoe
Ensure we're using the internal_value API for fields incase a field…
63bd5d0 
… needs to override this for some reason in the future
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
c4f8110 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
Fix missing import from test
4b2a872
@JeffersonBledsoe
Fix test being incorrect
aa3c786
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
49f7df8
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
6fd8d93 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
@JeffersonBledsoe
Cleanup bad merge
a26d13c
@JeffersonBledsoe
Fix missing use of fields from bad merge
9b64a9d
@JeffersonBledsoe
Update outdated status codes
81d9174
@JeffersonBledsoe
lint
a08bf7b
@JeffersonBledsoe
Wrong code updated....
b5936dd
@JeffersonBledsoe
Fix test for custom display value
f7b62ff
@JeffersonBledsoe
Fix cleanup of custom_field_id
e716145
@JeffersonBledsoe
Update test for send action form to match actual data
c806b31
@JeffersonBledsoe
lint
85a869b
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
d6ba9ea 
# Conflicts:
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
Use field class for date formatting
a094d68
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
3aadeda 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
#	src/collective/volto/formsupport/tests/test_send_action_form.py
@JeffersonBledsoe
lint
7d2cfcc
@JeffersonBledsoe
Use field class where possible
f8787cd
@JeffersonBledsoe
Fix sending attachments on accident
aa62f3c
@JeffersonBledsoe
Compute fields when they're needed so that events can still modify th…
b258131 
…e data
@JeffersonBledsoe
Send date, time and url in email if requested
cf6fca1
@JeffersonBledsoe
Store current URL if it's configured for saving
d507593
@JeffersonBledsoe
Safely access additionalInfo for backwards compat
0b20e78
@JeffersonBledsoe
Fix sending URL from some contexts and allow sending title as an addi…
f283b92 
…tional field
@JeffersonBledsoe
Fix label for page title in email
8bd3796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JeffersonBledsoe