Autoload fish completions and fix Makefile (#645)

* Change fish completion filename

why:
- Fish uses the filename of a completion file to determine which command
  the completions are for when autoloading them. The previous filename
  meant completions weren't being autoloaded.

* Use path package to build completion path

Path's are complicated and easy to get wrong. Let Go deal with it.

Makefile

@@ -15,7 +15,7 @@ clean:
 	rm ${PREFIX}/bin/dassume
 	rm ${PREFIX}/bin/dassume.fish
 
-aws-credentials: 
+aws-credentials:
 	echo -e "\nAWS_ACCESS_KEY_ID=\"$$AWS_ACCESS_KEY_ID\"\nAWS_SECRET_ACCESS_KEY=\"$$AWS_SECRET_ACCESS_KEY\"\nAWS_SESSION_TOKEN=\"$$AWS_SESSION_TOKEN\"\nAWS_REGION=\"$$AWS_REGION\""
 
 test-browser-binary:
@@ -49,11 +49,11 @@ ci-cli-all-platforms: test-binaries
 
 ## This will use the 'granted' binary and 'assume' symlink for dev build.
 ## Helpful to use dev build using 'granted' and 'assume' before release.
-cli-act-prod: go-binary assume-binary
+cli-act-prod: go-binary
 	mv ./bin/dgranted ${PREFIX}/bin/granted
 	ln -s granted ${PREFIX}/bin/dassumego
 	# replace references to "assumego" (the production binary) with "dassumego"
 	cat scripts/assume | sed 's/assumego/dassumego/g' > ${PREFIX}/bin/dassume && chmod +x ${PREFIX}/bin/dassume
 	cat scripts/assume.fish | sed 's/assumego/dassumego/g' > ${PREFIX}/bin/dassume.fish && chmod +x ${PREFIX}/bin/dassume.fish
 	mv ${PREFIX}/bin/dassume ${PREFIX}/bin/assume
-	mv ${PREFIX}/bin/dassume.fish ${PREFIX}/bin/assume.fish
+	mv ${PREFIX}/bin/dassume.fish ${PREFIX}/bin/assume.fish

pkg/granted/completion.go

@@ -62,7 +62,7 @@ func installFishCompletions(c *cli.Context) error {
 	// try to fetch user home dir
 	user, _ := user.Current()
 
-	executableDir := user.HomeDir + "/.config/fish/completions/granted_completer_fish.fish"
+	executableDir := path.Join(user.HomeDir, ".config/fish/completions", fmt.Sprintf("%s.fish", c.App.Name))
 
 	// Try to create a file
 	err := os.WriteFile(executableDir, []byte(combinedOutput), 0600)