Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning with latest python libs #1015

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pjotrp
Copy link

@pjotrp pjotrp commented Dec 14, 2018

These versions pass on my Guix build. You may need to edit some.

@cwl-bot
Copy link

cwl-bot commented Dec 14, 2018

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1015 into master will decrease coverage by 26.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1015       +/-   ##
===========================================
- Coverage    79.2%   52.93%   -26.27%     
===========================================
  Files          30       30               
  Lines        5996     5996               
  Branches     1488     1488               
===========================================
- Hits         4749     3174     -1575     
- Misses        873     2411     +1538     
- Partials      374      411       +37
Impacted Files Coverage Δ
cwltool/singularity.py 22.66% <0%> (-57.34%) ⬇️
cwltool/provenance.py 27.86% <0%> (-52.54%) ⬇️
cwltool/executors.py 34.59% <0%> (-47.57%) ⬇️
cwltool/docker.py 17.56% <0%> (-36.94%) ⬇️
cwltool/builder.py 52.22% <0%> (-34.08%) ⬇️
cwltool/update.py 37.73% <0%> (-30.19%) ⬇️
cwltool/command_line_tool.py 47.8% <0%> (-30.08%) ⬇️
cwltool/job.py 37.3% <0%> (-30.03%) ⬇️
cwltool/workflow.py 61.08% <0%> (-23.65%) ⬇️
cwltool/process.py 63.55% <0%> (-22.55%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49cd284...e973ad3. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1015 into master will decrease coverage by 26.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1015       +/-   ##
===========================================
- Coverage    79.2%   52.93%   -26.27%     
===========================================
  Files          30       30               
  Lines        5996     5996               
  Branches     1488     1488               
===========================================
- Hits         4749     3174     -1575     
- Misses        873     2411     +1538     
- Partials      374      411       +37
Impacted Files Coverage Δ
cwltool/singularity.py 22.66% <0%> (-57.34%) ⬇️
cwltool/provenance.py 27.86% <0%> (-52.54%) ⬇️
cwltool/executors.py 34.59% <0%> (-47.57%) ⬇️
cwltool/docker.py 17.56% <0%> (-36.94%) ⬇️
cwltool/builder.py 52.22% <0%> (-34.08%) ⬇️
cwltool/update.py 37.73% <0%> (-30.19%) ⬇️
cwltool/command_line_tool.py 47.8% <0%> (-30.08%) ⬇️
cwltool/job.py 37.3% <0%> (-30.03%) ⬇️
cwltool/workflow.py 61.08% <0%> (-23.65%) ⬇️
cwltool/process.py 63.55% <0%> (-22.55%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49cd284...15539fb. Read the comment docs.

@mr-c
Copy link
Member

mr-c commented Dec 14, 2018

Getting errors:

>       assert (master_run, PROV.wasAssociatedWith, engine) in g, "Wf run not associated with wf engine"
E       AssertionError: Wf run not associated with wf engine
E       assert (rdflib.term.URIRef(u'urn:uuid:ade29e98-83d3-44ec-88ec-5323bf95f29a'), rdflib.term.URIRef(u'http://www.w3.org/ns/prov#wasAssociatedWith'), rdflib.term.URIRef(u'urn:uuid:2a8057e9-aa75-4453-9dc4-101731822dc0')) in <Graph identifier=N0b510ca83152496fa728a8b8e97c8c18 (<class 'rdflib.graph.Graph'>)>
tests/test_provenance.py:410: AssertionError

@pjotrp
Copy link
Author

pjotrp commented Dec 26, 2018

I have cwltool running with Python 3.7. Had to disable type_extensions with 15539fb

@mr-c
Copy link
Member

mr-c commented Dec 26, 2018

@pjotrp Thanks for the update. How shall we proceed? We still support Python before 3.7, and your PR causes the tests to fail :-P

@pjotrp
Copy link
Author

pjotrp commented Dec 26, 2018

Just leave the PR pending. Someone can add conditionals for a backport. I'll see if we can confirm the failing tests at some point. Dependency issues most likely. Python is a pain. I am happy I have a working version on Python 3.7. We'll start hammering it!

@pjotrp pjotrp changed the title Versioning with lastest python libs Versioning with latest python libs Dec 26, 2018
@mr-c mr-c changed the base branch from master to main July 2, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants