-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning with latest python libs #1015
base: main
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
===========================================
- Coverage 79.2% 52.93% -26.27%
===========================================
Files 30 30
Lines 5996 5996
Branches 1488 1488
===========================================
- Hits 4749 3174 -1575
- Misses 873 2411 +1538
- Partials 374 411 +37
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
===========================================
- Coverage 79.2% 52.93% -26.27%
===========================================
Files 30 30
Lines 5996 5996
Branches 1488 1488
===========================================
- Hits 4749 3174 -1575
- Misses 873 2411 +1538
- Partials 374 411 +37
Continue to review full report at Codecov.
|
|
I have cwltool running with Python 3.7. Had to disable type_extensions with 15539fb |
@pjotrp Thanks for the update. How shall we proceed? We still support Python before 3.7, and your PR causes the tests to fail :-P |
Just leave the PR pending. Someone can add conditionals for a backport. I'll see if we can confirm the failing tests at some point. Dependency issues most likely. Python is a pain. I am happy I have a working version on Python 3.7. We'll start hammering it! |
These versions pass on my Guix build. You may need to edit some.