-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce bind mounting (and thus --bind args) in containers. #1568
base: main
Are you sure you want to change the base?
Reduce bind mounting (and thus --bind args) in containers. #1568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DailyDreaming ; are the tests passing for you? They aren't for me or on CI
@DailyDreaming I recommend using the following test to guide you
From Line 62 in 352daf6
Here is the expected contents of
Right now I'm seeing the following
|
@tetron recommends doing this primarily only for the non-InitialWorkDirRequirement inputs (which are always read-only), and then once for each top-level InitialWorkDirRequirement entry |
There is a memory limit on the length of bind arguments one can pass in the CLI and we can hit that limit (particularly Toil, which handles directories differently and tries to export files individually). This PR stages individual input files into one directory if
STAGE_SRC_DIR
is specified, so that only one bind mount arg needs to be supplied on the commandline for all individual files.This attempts to hardlink first, and, failing that, will attempt to copy the files into the staging directory.
I need to make a test. Currently
os.environ.get('STAGE_SRC_DIR', os.path.join(tempfile.gettempdir(), 'cwl-stg-src-dir'))
is set just to have this run through CI/CD. I'll change toos.environ.get('STAGE_SRC_DIR', None)
once I make a test.