-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stale: enable cache #22701
stale: enable cache #22701
Conversation
only 30 PRs are processed per day, so cache is needed to keep state and continue from the last PRs of the last days.
🤖 Beep Boop! This pull request is making changes to '.github//'. 👋 @ericLemanissier @Croydon you might be interested. 😉 |
AFAIU, the error happens on this line because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not happy with this change, because it will give a whole write access. A second option would be running all PRs, but we have +600 now and it would reach out Github API rate limit.
On the other hand, this is an official Action maintained by Github, so I only fell safe because of this.
Still, I prefer waiting for actions/stale#1133, because more projects are affected because of this problem.
To be clear, it gives write access only to the endpoints listed in this "Actions" section: https://docs.github.com/en/rest/authentication/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28#repository-permissions-for-actions, not full write access to everything in the repo. I think we could process more PRs per run. AFAIU, operations are consumed only when pull requests are marked stale or closed. according to https://github.com/conan-io/conan-center-index/actions/runs/7810903828/job/21305055330#step:2:480, marking a PR stales costs 4 operations, and each batch of 100 PRs/issues inspected costs one operation. This means that we will in term still process all PRs even without cache. |
@ericLemanissier Yes, I read the documentation. Still, the author is aware about and more repositories are being affected. I would prefer waiting for a real fix than trying a workaround which would give more permissions now. Thank you for giving more context about the situation. |
only 30 PRs are processed per day, so cache is needed to keep state and continue from the last PRs of the last days.
fixes error https://github.com/conan-io/conan-center-index/actions/runs/7810903828/job/21305055330#step:2:1032
cf actions/stale#1090 (comment)