Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for SFCGAL 2.0.0 #28964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lbartoletti
Copy link

@lbartoletti lbartoletti commented Jan 28, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/sfcgal/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: <votre_nom_d'utilisateur_github>. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sfcgal/meta.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/sfcgal/meta.yaml:

  • ℹ️ The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13011031005. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@lbartoletti lbartoletti force-pushed the add-sfcgal branch 3 times, most recently from 5c486ff to 8bfa998 Compare January 28, 2025 13:23
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sfcgal/meta.yaml:

  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13011595024. Examine the logs at this URL for more detail.

@lbartoletti lbartoletti force-pushed the add-sfcgal branch 2 times, most recently from aaffde3 to 628f313 Compare January 28, 2025 14:29
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found it was in an excellent condition.

@lbartoletti lbartoletti force-pushed the add-sfcgal branch 5 times, most recently from affdbf0 to c209cc1 Compare January 29, 2025 08:25
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sfcgal/meta.yaml:

  • ❌ The "outputs" section was expected to be a list, but got a ruamel.yaml.comments.CommentedMap.
  • ❌ The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].
  • ❌ The "outputs" section was expected to be a list, but got a ruamel.yaml.comments.CommentedMap.
  • ❌ The "outputs" section was expected to be a list, but got a ruamel.yaml.comments.CommentedMap.
  • ❌ The "outputs" section was expected to be a list, but got a ruamel.yaml.comments.CommentedMap.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13027266391. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found it was in an excellent condition.

@lbartoletti lbartoletti force-pushed the add-sfcgal branch 3 times, most recently from 65869b3 to 7d9e3bd Compare January 31, 2025 08:47
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sfcgal/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [39]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13069338309. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sfcgal/meta.yaml) and found it was in an excellent condition.

@lbartoletti lbartoletti marked this pull request as ready for review January 31, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants