Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gofmt 1.19; Fix bundle-import.sh to generate correct output #1110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanj
Copy link
Contributor

@evanj evanj commented Dec 1, 2023

Go 1.19 introduced gofmt formatting changes. This change runs gofmt from Go 1.19, since commit 09f2d70 on 2023-07-14 updated to use that version. It also fixes bundle-import.sh to generate the correct output. The changes are:

  • Add the new "//go:build" format lines
  • Put "// +build" tags on one line
  • Ensure the correct number of newlines

With these changes, future runs of bundle-import.sh should generate output that is not changed by running gofmt, with one exception: The libs line for Windows has a \r\n line ending, since it comes from the pkg-config .pc file which has \r\n line endings. I have left this unmodified.

kafka/README.md: Update link to correct location

See Go 1.19 release notes for details about gofmt changes: https://tip.golang.org/doc/go1.19#go-doc

Go 1.19 introduced gofmt formatting changes. This change runs gofmt
from Go 1.19, since commit 09f2d70 on 2023-07-14 updated to use
that version. It also fixes bundle-import.sh to generate the correct
output. The changes are:

* Add the new "//go:build" format lines
* Put "// +build" tags on one line
* Ensure the correct number of newlines

With these changes, future runs of bundle-import.sh should generate
output that is not changed by running gofmt, with one exception:
The libs line for Windows has a \r\n line ending, since it comes from
the pkg-config .pc file which has \r\n line endings. I have left this
unmodified.

kafka/README.md: Update link to correct location

See Go 1.19 release notes for details about gofmt changes:
https://tip.golang.org/doc/go1.19#go-doc
@milindl
Copy link
Contributor

milindl commented Feb 12, 2024

Thanks for this PR!
I think we'll soon need to update to go1.21 due to certain dependencies requiring it to be updated.
I'll update this PR and merge it then after the 1.21 and dependency update PR is in.

@milindl
Copy link
Contributor

milindl commented Feb 20, 2024

I'll merge #1136 first, and then, this. It updates the go version (both the supported and development versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants