[consumer] Propagate errors for Pause/Resume APIs #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This propagates the individual errors for each TopicPartition that is being Paused/Resumed, into the input slice itself. An non-nil cumulative error is returned in case one or more of the TopicPartitions has an error. This approach is different from other such APIs, which return a new slice of TopicPartitions, but that would break the API. This method keeps the existing API to not break existing code, but allows users to access errors which were not being made available earlier through the input.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates the individual errors for each TopicPartition
that is being Paused/Resumed, into the input slice itself.
An non-nil cumulative error is returned in case one or more of
the TopicPartitions has an error.
This approach is different from other such APIs, which return a
new slice of TopicPartitions, but that would break the API.
This method keeps the existing API to not break existing code, but
allows users to access errors which were not being made available
earlier through the input.
Fixes #808